[Commits] [SCM] claws branch, master, updated. 3.9.2-123-g2b703d8

mones at claws-mail.org mones at claws-mail.org
Mon Nov 25 20:26:56 CET 2013


The branch master of project "claws" (Claws Mail) has been updated
       via  2b703d81489a7132f08ad0abcff6c58495f960cd (commit)
       via  367aa54c16cdfbe946d26c133083b2ae1d715791 (commit)
      from  7eb6858477c1633c7957326edd6efe200cd091a5 (commit)


- Log -----------------------------------------------------------------
commit 2b703d81489a7132f08ad0abcff6c58495f960cd
Author: Ricardo Mones <ricardo at mones.org>
Date:   Mon Nov 25 20:22:00 2013 +0100

    Clean poppler_viewer.c switch warnings
    
    Cleans:
     • poppler_viewer.c:827:3: warning: enumeration value
       'POPPLER_ACTION_NONE' not handled in switch
     • poppler_viewer.c:827:3: warning: enumeration value
       'POPPLER_ACTION_RENDITION' not handled in switch
     • poppler_viewer.c:827:3: warning: enumeration value
       'POPPLER_ACTION_OCG_STATE' not handled in switch
     • poppler_viewer.c:827:3: warning: enumeration value
       'POPPLER_ACTION_JAVASCRIPT' not handled in switch

diff --git a/src/plugins/pdf_viewer/poppler_viewer.c b/src/plugins/pdf_viewer/poppler_viewer.c
index 4f90908..f1b6b1e 100644
--- a/src/plugins/pdf_viewer/poppler_viewer.c
+++ b/src/plugins/pdf_viewer/poppler_viewer.c
@@ -877,9 +877,25 @@ static void pdf_viewer_button_press_events_cb(GtkWidget *widget, GdkEventButton
 		case POPPLER_ACTION_NAMED:
 			debug_print("action named not yet implemented\n");
 			break;
+		case POPPLER_ACTION_NONE:
+			debug_print("action none does nothing, surprise!\n");
+			break;
+#if POPPLER_CHECK_VERSION(0,14,0)
 		case POPPLER_ACTION_MOVIE:
 			debug_print("yoyoyo ;-) a movie?\n");
 			break;
+		case POPPLER_ACTION_RENDITION:
+			debug_print("yoyoyo ;-) multimedia?\n");
+			break;
+		case POPPLER_ACTION_OCG_STATE:
+			debug_print("yoyoyo ;-) layer state?\n");
+			break;
+#if POPPLER_CHECK_VERSION(0,18,0)
+		case POPPLER_ACTION_JAVASCRIPT:
+			debug_print("yoyoyo ;-) javascript?\n");
+			break;
+#endif /* 0.18 */
+#endif /* 0.14 */
 		}
 		if (((MimeViewer *)viewer)->mimeview && 
 			((MimeViewer *)viewer)->mimeview->messageview && 

commit 367aa54c16cdfbe946d26c133083b2ae1d715791
Author: Ricardo Mones <ricardo at mones.org>
Date:   Mon Nov 25 20:20:00 2013 +0100

    Clean ‘newmail.c:132: warning: `sys_errlist' is deprecated’

diff --git a/src/plugins/newmail/newmail.c b/src/plugins/newmail/newmail.c
index 54004a5..db8c57e 100644
--- a/src/plugins/newmail/newmail.c
+++ b/src/plugins/newmail/newmail.c
@@ -39,6 +39,7 @@
 
 #define LOG_NAME	"NewLog"
 #define DEFAULT_DIR	"Mail"
+#define BUFSIZE		2048
 
 static guint hook_id;
 
@@ -128,9 +129,17 @@ gint plugin_init (gchar **error)
 			g_free(LogName);
 			LogName = g_strconcat(get_rc_dir(), G_DIR_SEPARATOR_S, LOG_NAME, NULL);
 			if (!(NewLog = fopen (LogName, mode))) {
+				char buf[BUFSIZE];
+
 				debug_print ("Failed to open fallback log %s\n", LogName);
+#if (_POSIX_C_SOURCE >= 200112L || _XOPEN_SOURCE >= 600) && ! _GNU_SOURCE
+				strerror_r(errno, buf, BUFSIZE);
+				*error = g_strdup_printf(_("Could not open log file %s: %s\n"),
+						LogName, buf);
+#else /* use GNU version */
 				*error = g_strdup_printf(_("Could not open log file %s: %s\n"),
-						LogName, sys_errlist[errno]);
+						LogName, strerror_r(errno, buf, BUFSIZE));
+#endif
 				plugin_done ();
 				return (-1);
 			}

-----------------------------------------------------------------------

Summary of changes:
 src/plugins/newmail/newmail.c           |   11 ++++++++++-
 src/plugins/pdf_viewer/poppler_viewer.c |   16 ++++++++++++++++
 2 files changed, 26 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Claws Mail


More information about the Commits mailing list