[Commits] prefswindow.c 1.12.2.60 1.12.2.61

[Andrej Kacian]

On Wed, 25 Jul 2012 18:51:46 +0000
ticho at claws-mail.org wrote:

> +
> +	manage_window_focus_in(prefswindow->window, NULL, NULL);

I'm not quite comfortable with this mechanic (setting a global focus_window
pointer which is later used by manage_window_set_transient() for various
dialogs), and would rather get rid of it for preferences window, relying on
vanilla gtk_window_set_transient_for() where necessary to set the
"transient for" property.

The manage_window_focus_in and _out functions are meant to be used as
callbacks for "focus_in_event" and "focus_out_event" GTK events, but they are
already being called directly in several places around the code.

The whole managed_window_*() stuff seems a bit out of place in an application
where window hierarchy is always clear, and "transiency" (is that even a
word?) doesn't have to rely on which window was focused last.

Regards,
-- 
Andrej Kacian