[Commits] ChangeLog 1.396.2.3556 1.396.2.3557 Makefile.am 1.24.2.29 1.24.2.30 PATCHSETS 1.1.2.4387 1.1.2.4388 configure.ac 1.654.2.4454 1.654.2.4455

[Holger Berndt]

On So, 01.07.2012 08:27, Paul wrote:

>> Problem will probably arise for any core structure with members
>> depending on configure options, like for example Compose's
>> WITH_ASPELL stuff...
>> 
>> Or am I wrong ?
>
>I haven't found any problems so far.

I think Colin is right, though. When plugins use Claws Mail's
structures, and have a wrong idea about member offsets due to unknown
preprocessor macro definitions, undefined behaviour und undebuggable
bugs might result.

I reopened the bug because I think the reporter has a point that should
not be forgotten, but it might not be trivial to solve. In particular,
we should be careful that during a cleanup, we don't introduce more
serious hard-to-track problems.

One way around it might be to introduce an additional config header that
contains those defines needed in public structures (and no more), and
install that one. That's more a workaround than a clean fix too, but at
least it doesn't have the problems that an installed config.h does.

Holger