[Users] Claws Mail 3.14.1 unleashed!!

[Richard]

> Date: Monday, November 07, 2016 16:33:59 +0000
> From: Paul <claws at thewildbeast.co.uk>
>
> On Mon, 07 Nov 2016 15:57:20 +0000
> Richard  wrote: 
> 
>> On a centos-7.2 system the compile fails in the included gdata
>> plugin. Dropping that plugin out lets the compile complete, and on
>> quick/minimal testing, this new release otherwise seems to work
>> fine.
>> 
>> With 3.14.0, the gdata plugin compiled ok and worked. I see that
>> there were some changes to that plugin between versions, but
>> haven't otherwise poked into this much.
> 
> The ./configure output will tell you why it fails. But by 'fail' do
> you mean that the gdata plugin is not built?
> 
> with regards
> 
> Paul

It passes the ./configure:

configure:21199: checking for GDATA
configure:21206: $PKG_CONFIG --exists --print-errors "libgdata >=
0.17.1"
configure:21209: $? = 0
configure:21223: $PKG_CONFIG --exists --print-errors "libgdata >=
0.17.1"
configure:21226: $? = 0
configure:21264: result: yes
 ... 
configure:22710: checking whether to build gdata plugin
configure:22721: result: yes
 ...
config.status:1531: creating src/plugins/gdata/Makefile
 ...
BUILD_GDATA_PLUGIN_FALSE='#'
BUILD_GDATA_PLUGIN_TRUE=''
 ...
GDATA_CFLAGS='-pthread -I/usr/include/libgdata -I/usr/include/gcr-3
-I/usr/include/libxml2 -I/usr/include/goa-1.0
-I/usr/lib64/goa-1.0/include -I/usr/include/glib-2.0
-I/usr/lib64/glib-2.0/include -I/usr/include/libsoup-2.4
-I/usr/include/json-glib-1.0 -I/usr/include/nss3 -I/usr/include/nspr4
-I/usr/include/gck-1 -I/usr/include/p11-kit-1  '
GDATA_LIBS='-lgdata -lxml2 -lsoup-2.4 -ljson-glib-1.0 -lgio-2.0
-lgobject-2.0 -lglib-2.0  '


but it "blows up" on the actual compile of the plugin:

cm_gdata_contacts.c: In function 'query':
cm_gdata_contacts.c:569:107: error: 'cm_gdata_refresh_ready'
undeclared (first use in this function)

gdata_authorizer_refresh_authorization_async(GDATA_AUTHORIZER(authorizer),
NULL, (GAsyncReadyCallback)cm_gdata_refresh_ready, NULL);

^
cm_gdata_contacts.c:569:107: note: each undeclared identifier is
reported only once for each function it appears in
cm_gdata_contacts.c:530:10: warning: unused variable 'token'
[-Wunused-variable]
   gchar *token;
          ^
cm_gdata_contacts.c: In function 'cm_gdata_contacts_done':
cm_gdata_contacts.c:644:10: warning: unused variable 'pass'
[-Wunused-variable]
   gchar *pass;
          ^
make[5]: *** [gdata_la-cm_gdata_contacts.lo] Error 1


If I use the cm_gdata_contacts.c code from .0, instead of what's
included with .1 it will compile under .1 (after doing a "make clean"
and "make" in that plugin's directory), and will load and pop up the
"GData plugin: Authorization required" box. I didn't go further and
try authenticating with google.