[Commits] [SCM] claws branch, master, updated. 3.14.0-61-g6809ce7

mones at claws-mail.org mones at claws-mail.org
Sat Sep 3 01:20:53 CEST 2016


The branch, master has been updated
       via  6809ce7893a584f7d5a86a06959d9bbd71a8fcd3 (commit)
       via  001f97e114aeb6d633de63abc08db157cc8c0fcf (commit)
      from  b130471c6066581ae882fa049603e2e3567585c7 (commit)

Summary of changes:
 src/prefs_folder_item.c |   56 +++++++++++++++++++++++++----------------------
 src/prefs_folder_item.h |    7 ++----
 2 files changed, 32 insertions(+), 31 deletions(-)


- Log -----------------------------------------------------------------
commit 6809ce7893a584f7d5a86a06959d9bbd71a8fcd3
Author: Ricardo Mones <ricardo at mones.org>
Date:   Sat Sep 3 01:20:17 2016 +0200

    Remove unused declaration

diff --git a/src/prefs_folder_item.h b/src/prefs_folder_item.h
index 189ae29..d3a4d08 100644
--- a/src/prefs_folder_item.h
+++ b/src/prefs_folder_item.h
@@ -1,6 +1,6 @@
 /*
- * Sylpheed -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 1999-2012 Hiroyuki Yamamoto and the Claws Mail team
+ * Claws Mail -- a GTK+ based, lightweight, and fast e-mail client
+ * Copyright (C) 1999-2016 Hiroyuki Yamamoto and the Claws Mail team
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -14,7 +14,6 @@
  *
  * You should have received a copy of the GNU General Public License
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
- * 
  */
 
 #ifndef PREFS_FOLDER_ITEM_H
@@ -28,8 +27,6 @@
 #include "folder_item_prefs.h"
 #include "prefswindow.h"
 
-void prefs_folder_item_create(FolderView *folderview, FolderItem *item); 
-
 void prefs_folder_item_open		(FolderItem 	*item);
 
 void prefs_folder_item_register_page(PrefsPage *page, FolderClass *klass);

commit 001f97e114aeb6d633de63abc08db157cc8c0fcf
Author: Ricardo Mones <ricardo at mones.org>
Date:   Sat Sep 3 01:18:56 2016 +0200

    Add warning icon to warning message
    
    Refactor warning creation code into a single function.

diff --git a/src/prefs_folder_item.c b/src/prefs_folder_item.c
index 6990206..404aba9 100644
--- a/src/prefs_folder_item.c
+++ b/src/prefs_folder_item.c
@@ -1,6 +1,6 @@
 /*
  * Claws Mail -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 1999-2015 Hiroyuki Yamamoto and the Claws Mail team
+ * Copyright (C) 1999-2016 Hiroyuki Yamamoto and the Claws Mail team
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -14,7 +14,6 @@
  *
  * You should have received a copy of the GNU General Public License
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
- * 
  */
 
 /* alfons - all folder item specific settings should migrate into 
@@ -50,6 +49,7 @@
 #include "string_match.h"
 #include "quote_fmt.h"
 #include "combobox.h"
+#include "stock_pixmap.h"
 
 #if USE_ENCHANT
 #include "gtkaspell.h"
@@ -196,6 +196,28 @@ static void folder_regexp_set_subject_example_cb(GtkWidget *widget, gpointer dat
 #define SAFE_STRING(str) \
 	(str) ? (str) : ""
 
+static GtkWidget *prefs_folder_no_save_warning_create_widget() {
+	GtkWidget *hbox;
+	GtkWidget *icon;
+	GtkWidget *label;
+
+	hbox = gtk_hbox_new(FALSE, 0);
+
+	icon = stock_pixmap_widget(STOCK_PIXMAP_NOTICE_WARN);
+	gtk_box_pack_start(GTK_BOX(hbox), icon, FALSE, FALSE, 8);
+
+	label = gtk_label_new(g_strconcat("<i>",
+		_("These preferences will not be saved as this folder "
+		"is a top-level folder.\nHowever, you can set them for the "
+		"whole mailbox tree by using \"Apply to subfolders\"."),
+		"</i>", NULL));
+	gtk_label_set_use_markup(GTK_LABEL(label), TRUE);
+	gtk_misc_set_alignment(GTK_MISC(label), 0.0, 0.5);
+	gtk_box_pack_start(GTK_BOX(hbox), label, TRUE, TRUE, 0);
+
+	return hbox;
+}
+
 static void prefs_folder_item_general_create_widget_func(PrefsPage * page_,
 						   GtkWindow * window,
                                 		   gpointer data)
@@ -213,7 +235,6 @@ static void prefs_folder_item_general_create_widget_func(PrefsPage * page_,
 	GtkTreeIter iter;
 	GtkWidget *dummy_checkbtn, *clean_cache_btn;
 	SpecialFolderItemType type;
-	
 	GtkWidget *no_save_warning = NULL;
 
 	GtkWidget *checkbtn_simplify_subject;
@@ -258,15 +279,9 @@ static void prefs_folder_item_general_create_widget_func(PrefsPage * page_,
 	rowcount = 0;
 
 	if (!can_save) {
-		no_save_warning = gtk_label_new(g_strconcat("<i>",
-			_("These preferences will not be saved as this folder "
-			"is a top-level folder. However, you can set them for the "
-			"whole mailbox tree by using \"Apply to subfolders\"."), "</i>", NULL));
-		gtk_label_set_use_markup(GTK_LABEL(no_save_warning), TRUE);
-		gtk_label_set_line_wrap(GTK_LABEL(no_save_warning), TRUE);
-		gtk_misc_set_alignment(GTK_MISC(no_save_warning), 0.0, 0.5);
+		no_save_warning = prefs_folder_no_save_warning_create_widget();
 		gtk_table_attach(GTK_TABLE(table), no_save_warning, 0, 3,
-			 rowcount, rowcount + 1, GTK_FILL, 0, 0, 0);
+			rowcount, rowcount + 1, GTK_FILL, 0, 0, 0);
 		rowcount++;
 	}
 	
@@ -860,13 +875,7 @@ static void prefs_folder_item_compose_create_widget_func(PrefsPage * page_,
 	rowcount = 0;
 
 	if (!can_save) {
-		no_save_warning = gtk_label_new(g_strconcat("<i>",
-			_("These preferences will not be saved as this folder "
-			"is a top-level folder. However, you can set them for the "
-			"whole mailbox tree by using \"Apply to subfolders\"."), "</i>", NULL));
-		gtk_label_set_use_markup(GTK_LABEL(no_save_warning), TRUE);
-		gtk_label_set_line_wrap(GTK_LABEL(no_save_warning), TRUE);
-		gtk_misc_set_alignment(GTK_MISC(no_save_warning), 0.0, 0.5);
+		no_save_warning = prefs_folder_no_save_warning_create_widget();
 		gtk_table_attach(GTK_TABLE(table), no_save_warning, 0, 3,
 			 rowcount, rowcount + 1, GTK_FILL, 0, 0, 0);
 		rowcount++;
@@ -1386,14 +1395,9 @@ static void prefs_folder_item_templates_create_widget_func(PrefsPage * page_,
 	gtk_widget_show (page_vbox);
 	
 	if (!can_save) {
-		no_save_warning = gtk_label_new(g_strconcat("<i>",
-			_("These preferences will not be saved as this folder "
-			"is a top-level folder. However, you can set them for the "
-			"whole mailbox tree by using \"Apply to subfolders\"."), "</i>", NULL));
-		gtk_label_set_use_markup(GTK_LABEL(no_save_warning), TRUE);
-		gtk_label_set_line_wrap(GTK_LABEL(no_save_warning), TRUE);
-		gtk_misc_set_alignment(GTK_MISC(no_save_warning), 0.0, 0.5);
-		gtk_box_pack_start(GTK_BOX(page_vbox), no_save_warning, FALSE, FALSE, 0);
+		no_save_warning = prefs_folder_no_save_warning_create_widget();
+		gtk_box_pack_start(GTK_BOX(page_vbox),
+				   no_save_warning, FALSE, FALSE, 0);
 	}
 
 	/* Notebook */

-----------------------------------------------------------------------


hooks/post-receive
-- 
Claws Mail


More information about the Commits mailing list