[Commits] [SCM] claws branch, master, updated. 3.10.0-30-g5f52f11

mones at claws-mail.org mones at claws-mail.org
Sun Jun 1 16:03:18 CEST 2014


The branch master of project "claws" (Claws Mail) has been updated
       via  5f52f113ac9fd054f10752febbfac340c38cddbe (commit)
      from  3ae5095cb57a018fc7b11e1b9f71495f3bbc83e2 (commit)


- Log -----------------------------------------------------------------
commit 5f52f113ac9fd054f10752febbfac340c38cddbe
Author: Fabian Keil <fk at fabiankeil.de>
Date:   Sun Jun 1 13:55:20 2014 +0200

    Fix bug #3201 "Fix memory corruption in sc_html_read_line()"
    
    Previously fread() could fill the whole buffer
    in which case buf[n] = '\0' messed up the stack.
    
    Introduced in d0c64a09 + 4ab3585743.

diff --git a/src/html.c b/src/html.c
index f7b0ac4..71338af 100644
--- a/src/html.c
+++ b/src/html.c
@@ -445,7 +445,7 @@ static SC_HTMLState sc_html_read_line(SC_HTMLParser *parser)
 	if (parser->fp == NULL)
 		return SC_HTML_EOF;
 
-	n = fread(buf, 1, sizeof(buf), parser->fp);
+	n = fread(buf, 1, sizeof(buf) - 1, parser->fp);
 	if (n == 0) {
 		parser->state = SC_HTML_EOF;
 		return SC_HTML_EOF;

-----------------------------------------------------------------------

Summary of changes:
 src/html.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


hooks/post-receive
-- 
Claws Mail


More information about the Commits mailing list